Remove text logo from README #38887
Merged
Remove text logo from README #38887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently causes a scrollbar to appear which is, in my opinion, unacceptable. It's also pretty much illegible.
|
I see the same horizontal scrollbar, in both Chrome and Firefox. Regardless of screen size, the ASCII-art logo will not fit (as if the regular github style has an insufficient maximum width). On a smaller device like a mobile, it's completely truncated. It was a nice idea, but I agree that READMEs should be readable first. |
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
Mar 19, 2020
Merge pull request CleverRaven#38887 from ifreund/readme-fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
The ascii-art text header causes a scrollbar to appear at every zoom level I've tried which is, in my opinion, unacceptable. It's also far less legible than the markdown header.
Describe the solution
Use markdown for its intended purpose.
Testing
loaded the page on my branch https://github.com/ifreund/Cataclysm-DDA/tree/readme-fmt