clang -Wimplicit-int-float-conversion fixes #38886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
commented
Mar 19, 2020
kevingranade
commented
Mar 19, 2020
ZhilkinSerg
added
the
[C++]
ZhilkinSerg
reviewed
Mar 19, 2020
ZhilkinSerg
reviewed
Mar 19, 2020
ZhilkinSerg
reviewed
Mar 19, 2020
ZhilkinSerg
reviewed
Mar 19, 2020
| @@ -1237,8 +1237,12 @@ float fastexp( float x ) | |||
| float f; | |||
| int i; | |||
| } u, v; | |||
| #pragma GCC diagnostic push | |||
| #pragma GCC diagnostic ignored "-Wpragmas" | |||
There was a problem hiding this comment.
Is it the same thing as I did in #38431?
#pragma GCC diagnostic ignored "-Wunknown-pragmas"
There was a problem hiding this comment.
No, this one means "STFU about any warnings related to pragmas".
GCC was choking on the other ignored pragma because it didn't recognize the warning flag.
Co-Authored-By: ZhilkinSerg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fixes #36510
Fixes #37006
Clang 10 adds a new warning, this corrects our code or silences the warning when "we know better":tm:
Describe the solution
Replace INT_MAX with FLT_MAX in a number of places.
Silence the warning due to the hackery in fastexp().
Describe alternatives you've considered
Could silence more of the warnings, but FLT_MAX seems to be correct in all of those cases.
Could use std::numeric_limits::max() instead, but that's kind of just bikeshedding.
Additional Context
This replaces #38881 since something about github permissions prevents me from applying a fix to that one.