Make carried vehicle cargo available for storage #38681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Make carried vehicle cargo available for storage"Purpose of change
Fixes #38671 by allowing carried vehicle cargo to be usable in advanced inventory and when dropping items.
Describe the solution
The is_available() check was specifically excluding items with the carried flag, so I changed the check to use !is_broken() instead of is_available().
I couldn't think of a case where this would cause a problem, and I tested carrying lone parts like cargo carriers to make sure this didn't introduce some exploit and couldn't find one, but I would like feedback if I'm missing something.
Describe alternatives you've considered
I think this is the right solution.
Testing
Spawned motorbikes with storage and mounted on cars with bike racks, and then interacted with the storage using both AIM and by just dropping items in the carrier.
Additional context
As mentioned, I couldn't think of an exploit this would allow but let me know if you think of any.