Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with ascii title #38680

Merged
merged 5 commits into from
Mar 18, 2020

Conversation

cosmiccoincidence
Copy link
Contributor

@cosmiccoincidence cosmiccoincidence commented Mar 10, 2020

Summary

SUMMARY: Infrastructure "Updates README.md with ascii title"

Purpose of change

To update the 'front page' of the repo with a graphic for the new .E release.

  • Adds a new title image to the README.md
  • moves the status images
  • minor grammar fixes/changes

Describe the solution

I used the same 'logo' used in-game and on the reddit.

Testing

Light Theme | Dark Theme

(new versions in comment down below)

Additional context

If you aren't a fan of parts of the change, lmk.

@Leland
Copy link
Contributor

Leland commented Mar 10, 2020

Cyan is super tough to read on a white background

@ZhilkinSerg
Copy link
Contributor

   _________            __                   .__                                
   \_   ___ \ _____   _/  |_ _____     ____  |  |   ___.__   ______  _____      
   /    \  \/ \__  \  \   __\\__  \  _/ ___\ |  |  <   |  | /  ___/ /     \     
   \     \____ / __ \_ |  |   / __ \_\  \___ |  |__ \___  | \___ \ |  Y Y  \    
    \______  /(____  / |__|  (____  / \___  >|____/ / ____|/____  >|__|_|  /    
           \/      \/             \/      \/        \/          \/       \/     
    ________                   .__      ________                                
    \______ \  _____   _______ |  | __  \______ \  _____    ___.__   ______     
     |    |  \ \__  \  \_  __ \|  |/ /   |    |  \ \__  \  <   |  | /  ___/     
     |    `   \ / __ \_ |  | \/|    <    |    `   \ / __ \_ \___  | \___ \      
    /_______  /(____  / |__|   |__|_ \  /_______  /(____  / / ____|/____  >     
            \/      \/              \/          \/      \/  \/          \/      
                     _____   .__                         .___                   
                    /  _  \  |  |__    ____  _____     __| _/                   
                   /  /_\  \ |  |  \ _/ __ \ \__  \   / __ |                    
                  /    |    \|   Y  \\  ___/  / __ \_/ /_/ |                    
                  \____|__  /|___|  / \___  >(____  /\____ |                    
                          \/      \/      \/      \/      \/                    

@ZhilkinSerg ZhilkinSerg added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs labels Mar 10, 2020
@cosmiccoincidence
Copy link
Contributor Author

I agree cyan may not be easily readable against white. I was simply using the colors in the game... I came up with an alternative that might be more appealing (lime green):

Light Theme | Dark Theme

But since @ZhilkinSerg posted the actual ascii (thanks), here is that version:

Light Theme | Dark Theme

Which I think looks pretty good (obviously more concerned about the standard light theme), but felt the corners could use something, so I threw together a quick biohazard ascii symbol to put there:

Light Theme | Dark Theme

Let me know what you guys like and I'll update the PR with it.

@cosmiccoincidence cosmiccoincidence changed the title Update README.md with new image [WIP] Update README.md with new image Mar 10, 2020
@AMurkin
Copy link
Contributor

AMurkin commented Mar 11, 2020

image
Can the text glow, since this is an image?

@cosmiccoincidence
Copy link
Contributor Author

Ultimately is up to what the devs like... But my first (colored) attempts were images, but the later two are just pure ascii in the text, not even a picture file. I can test your image but you should export it without a background. Just a transparent image with only the text. Could you do that and I'll try to make it work? @AMurkin

@AMurkin
Copy link
Contributor

AMurkin commented Mar 11, 2020

the later two are just pure ascii

I didn't catch that the final version will not be an image. And this is for the better due to the fact that it's possible to customize the style on the user side.
Nevermind my previous comment.

@cosmiccoincidence
Copy link
Contributor Author

Since I havent received anymore opinions recently, I updated it to the ascii version without the extra symbols, and you can see it running on my branch.

@cosmiccoincidence cosmiccoincidence changed the title [WIP] Update README.md with new image Update README.md with new image Mar 13, 2020
@cosmiccoincidence cosmiccoincidence changed the title Update README.md with new image Update README.md with ascii title Mar 13, 2020
@olanti-p
Copy link
Contributor

olanti-p commented Mar 13, 2020

I think the blue+green image version looked nice. Text is a bit finicky

Firefox 74.0 on Kubuntu
image

Same on Win10
image

@ZhilkinSerg ZhilkinSerg added the Organization: Sites Issues concerning web-sites that relate to Cataclysm label Mar 16, 2020
@cosmiccoincidence
Copy link
Contributor Author

cosmiccoincidence commented Mar 17, 2020

Personally I'm kinda leaning toward the ascii myself, as it's more true to the nature of the game. And you will also be able to see the ascii if you manually open the readme file, as opposed to seeing link to a image in the docs folder.

Also, it's probably gonna be impossible to tailor it to every web browser, I personally use Chrome, which I believe is the most popular.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 70ce2a2 into CleverRaven:master Mar 18, 2020
@cosmiccoincidence cosmiccoincidence deleted the readmeimg branch March 25, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs Organization: Sites Issues concerning web-sites that relate to Cataclysm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants