-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with ascii title #38680
Update README.md with ascii title #38680
Conversation
Cyan is super tough to read on a white background |
_________ __ .__ \_ ___ \ _____ _/ |_ _____ ____ | | ___.__ ______ _____ / \ \/ \__ \ \ __\\__ \ _/ ___\ | | < | | / ___/ / \ \ \____ / __ \_ | | / __ \_\ \___ | |__ \___ | \___ \ | Y Y \ \______ /(____ / |__| (____ / \___ >|____/ / ____|/____ >|__|_| / \/ \/ \/ \/ \/ \/ \/ ________ .__ ________ \______ \ _____ _______ | | __ \______ \ _____ ___.__ ______ | | \ \__ \ \_ __ \| |/ / | | \ \__ \ < | | / ___/ | ` \ / __ \_ | | \/| < | ` \ / __ \_ \___ | \___ \ /_______ /(____ / |__| |__|_ \ /_______ /(____ / / ____|/____ > \/ \/ \/ \/ \/ \/ \/ _____ .__ .___ / _ \ | |__ ____ _____ __| _/ / /_\ \ | | \ _/ __ \ \__ \ / __ | / | \| Y \\ ___/ / __ \_/ /_/ | \____|__ /|___| / \___ >(____ /\____ | \/ \/ \/ \/ \/ |
I agree cyan may not be easily readable against white. I was simply using the colors in the game... I came up with an alternative that might be more appealing (lime green): But since @ZhilkinSerg posted the actual ascii (thanks), here is that version: Which I think looks pretty good (obviously more concerned about the standard light theme), but felt the corners could use something, so I threw together a quick biohazard ascii symbol to put there: Let me know what you guys like and I'll update the PR with it. |
Ultimately is up to what the devs like... But my first (colored) attempts were images, but the later two are just pure ascii in the text, not even a picture file. I can test your image but you should export it without a background. Just a transparent image with only the text. Could you do that and I'll try to make it work? @AMurkin |
I didn't catch that the final version will not be an image. And this is for the better due to the fact that it's possible to customize the style on the user side. |
Since I havent received anymore opinions recently, I updated it to the ascii version without the extra symbols, and you can see it running on my branch. |
Personally I'm kinda leaning toward the ascii myself, as it's more true to the nature of the game. And you will also be able to see the ascii if you manually open the readme file, as opposed to seeing link to a image in the docs folder. Also, it's probably gonna be impossible to tailor it to every web browser, I personally use Chrome, which I believe is the most popular. |
Summary
SUMMARY: Infrastructure "Updates README.md with ascii title"
Purpose of change
To update the 'front page' of the repo with a graphic for the new .E release.
Describe the solution
I used the same 'logo' used in-game and on the reddit.
Testing
Light Theme | Dark Theme
(new versions in comment down below)
Additional context
If you aren't a fan of parts of the change, lmk.