Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Death to void params #38546

Merged
merged 4 commits into from
Mar 4, 2020
Merged

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented Mar 3, 2020

Summary

SUMMARY: None

Purpose of change

Based on comment.

Describe the solution

Comment parameters names, remove void casts, rewrite some code.

Describe alternatives you've considered

None.

Testing

It compiles. Both tiles and curses.

Additional context

Did not touch extern "C" block in the src/sdltiles.cpp.
Not sure if */*param*/ is a problem. Github shows it in red in the src/activity_handlers.cpp.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Mar 3, 2020
src/animation.cpp Outdated Show resolved Hide resolved
src/wish.cpp Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit d972c1c into CleverRaven:master Mar 4, 2020
@AMurkin AMurkin deleted the death-to-void-params branch March 4, 2020 03:28
@ZhilkinSerg
Copy link
Contributor

Not sure if */param/ is a problem. Github shows it in red in the src/activity_handlers.cpp.

VS complains about it too (*/ resembles closing of multiline comment, but without opening /*). I think warning can be avoided with additional whitespace after first asterisk (i.e. `* /param/).

@jkraybill
Copy link
Contributor

Yeah this is the error from VS:
warning C4138: '*/' found outside of comment

Would be nice to not have this, but it's not a dealbreaker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants