Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMP bombs no longer radically change mass when armed. 💣 #38446

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

pjf
Copy link
Contributor

@pjf pjf commented Feb 29, 2020

Summary

SUMMARY: Bugfixes "EMP bombs no longer radically change mass when armed"

Purpose of change

EMP bombs would gain 15kg of mass (and 500mL of volume) the moment they were armed, making them alarmingly hard to throw.

Describe the solution

Make armed bombs the same mass and volume as unarmed bombs.

Describe alternatives you've considered

Should be the other way around? Should the bomb be 4.5kg (the old unarmed mass) or almost 20kg (the old armed mass)?

Should I go through all the explosives and use copy-from, or are there dragons hiding behind changing use-actions?

Testing

Armed a bomb before and after applying the changes.

EMP bombs would gain 15kg of mass (and 500mL of volume) the moment they
were armed, making them alarmingly hard to throw.
Copy link
Member

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh, who could possibly have made this mistake!

@Brian-Otten
Copy link
Contributor

4.5 is the correct one

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact labels Feb 29, 2020
@kevingranade kevingranade merged commit 860bed4 into CleverRaven:master Mar 2, 2020
@pjf pjf deleted the emp_bomb_mass branch July 6, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants