Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the basic laboratory analysis set recipe accepting large boxes #38420

Closed
wants to merge 1 commit into from

Conversation

l29ah
Copy link
Contributor

@l29ah l29ah commented Feb 28, 2020

Summary

SUMMARY: Content "Make the basic laboratory analysis set recipe accepting large boxes"

Purpose of change

Since the proper size of a box is hard to find.

Describe the solution

Describe alternatives you've considered

Adding a box recipe.
Dropping the box requirement altogether.

Testing

Additional context

Since the proper size of a box is hard to find.
@sharkfinsouperman
Copy link

Since the proper size of a box is hard to find.

Medium boxes have the same spawn rate in residential homes as large boxes, and medium boxes of toilet paper are very common in washrooms, so I don't understand why this change is necessary or justified.

@l29ah
Copy link
Contributor Author

l29ah commented Feb 28, 2020

Just checked 13 washrooms in underground labs and found zero medium boxes. Do i have to get back in a city just to pick a proper box for all the research lab equipment i harvested in the lab?

@sharkfinsouperman
Copy link

Okay, according to the item locator, they don't spawn in underground labs at all.

This may be nothing more than an oversight when the objects were added. So rather than changing the recipe due to the lack of spawns in underground labs, perhaps it would make more sense to correct the oversight and set toilet paper to spawn inside the labs instead?

@l29ah
Copy link
Contributor Author

l29ah commented Feb 28, 2020

I consider requiring a toilet paper box in the recipe for the item that is necessary for mutagen production an oversight (as well).

@sharkfinsouperman
Copy link

I understand your frustration, but IMO changing the recipe affects the game globally, while adding toilet paper spawns to the lab solves your local issue without having any global effect.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Feb 28, 2020
@I-am-Erk
Copy link
Member

I-am-Erk commented Feb 28, 2020

A large cardboard box is big enough to hide inside, it's not a reasonable way to carry around an analytical set. Some reasonable solutions:

  • add a recipe to make a medium box out of cardboard scraps so you can chop up a large box and build a medium one
  • improve spawning of items in an underground lab since they should be overflowing with medium cardboard boxes

This is not a good solution as presented.

@I-am-Erk I-am-Erk closed this Feb 28, 2020
l29ah added a commit to l29ah/Cataclysm-DDA that referenced this pull request Feb 28, 2020
I-am-Erk pushed a commit that referenced this pull request Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants