Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context for item "basin" #38331

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

Aloxaf
Copy link
Contributor

@Aloxaf Aloxaf commented Feb 25, 2020

Summary

SUMMARY: None

Purpose of change

The item "basin" and terrain "basin" should in different context.

Describe the solution

Add context for item "basin".

Describe alternatives you've considered

Add context for terrain "basin" or both of them.

Testing

Ran lang/update_pot.sh and checked cataclysm-dda.pot

#: lang/json/CONTAINER_from_json.py
msgctxt "container"
msgid "basin"
msgid_plural "basins"
msgstr[0] ""
msgstr[1] ""

#: lang/json/overmap_terrain_from_json.py
msgid "basin"
msgstr ""

Additional context

The item "basin" and terrain "basin" should in different context.
@Aloxaf Aloxaf removed the request for review from John-Candlebury February 25, 2020 14:47
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Translation I18n labels Feb 25, 2020
@ZhilkinSerg ZhilkinSerg merged commit 65b99a1 into CleverRaven:master Feb 25, 2020
@Aloxaf Aloxaf deleted the ctxt_for_basin branch February 26, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants