Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧈 Move tainted tallow and poppy buds to the chemical category. 🌺 #38287

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

pjf
Copy link
Contributor

@pjf pjf commented Feb 24, 2020

Summary

SUMMARY: Interface "Tainted tallow and poppy buds are now in the chemicals category (was 'other')"

Purpose of change

Since these items are mostly used as feedstocks for chemistry labs, producing fuel and medicines, respectively, I feel it makes sense for them to go in the chemicals category, rather than 'other'.

Describe the solution

Added 'chems' category to tainted tallow and poppy buds.

Describe alternatives you've considered

Making tainted tallow a food? I mean, it's not something you want to eat...

Testing

Using in my local playthrough.

Additional context

I like the tradition of "suggestions as code", when it's easy to do so. These categories make sense to me, but I'm 100% cool if they don't get merged.

pjf added 2 commits February 23, 2020 17:25
Tainted tallow is a feedstock for oil production, and thus most likely
used in a chemlab.
Mutated poppies are a feedstock into various medicines, and thus most
likely used in a chemlab.
@pjf
Copy link
Contributor Author

pjf commented Feb 24, 2020

Q: Should this be "Interface" or "Balance"?

@Zireael07
Copy link
Contributor

IIRC categories are only used by the GUI, so Interface.

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks labels Feb 24, 2020
@Rivet-the-Zombie Rivet-the-Zombie merged commit 3166271 into CleverRaven:master Feb 25, 2020
@pjf pjf deleted the poppy_tallow_chems branch July 6, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants