Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home display case item group #38272

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

LilShiningMan
Copy link
Contributor

@LilShiningMan LilShiningMan commented Feb 23, 2020

Summary

SUMMARY: Infrastructure "added new item group for spawning in domestic display cases"

Purpose of change

There's not a single group (including art) that really covers the breadth of what might be found on display in a person's home. I tried to make a list that wasn't unwieldy and still managed to draw from many disparate lists.

Describe the solution

went through various lists and took a few entries from each that I thought would a) fit in a piece of furniture and b) offer some variety.

Describe alternatives you've considered

just using art in my house spawn lists, but that's a bit limited.

Testing

linted and debug spawned item list in game

Additional context

This PR just contains the list and does not introduce these spawns into the game. I am currently working on a house for submission that will call this list if it's merged.

As there are many different categories called in this list, it's probably best to only spawn a single item when called.

I also thought of possibly adding this list to the standard house palette, but I'm unsure if this is the best solution. When designing a house, I personally want a bit of control over what spawns in certain furniture and I haven't successfully found a way of overriding item spawns for palette furniture entries.

added new item group for spawning in domestic display cases
@I-am-Erk
Copy link
Member

This does need to appear somewhere. In the nested maps I added to house basements there is a basement with display cases that would fit it well.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Spawn Creatures, items, vehicles, locations appearing on map labels Feb 24, 2020
@kevingranade kevingranade merged commit 8cab702 into CleverRaven:master Apr 2, 2020
@ZhilkinSerg
Copy link
Contributor

Will need a follow-up to use that group in some mapgen (or other item groups).

We also probably need some test/script to check whether item groups are actually used by anything.

@LilShiningMan
Copy link
Contributor Author

It looks like someone beat me to this already by adding it to the display case spawn, but I've just submitted a PR to add this list to the standard house palette for the glass cabinet furniture spawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants