SIG SG magazines and rifles

[SnowFreeTrack]

Summary

SUMMARY: Content "Adds SIG SG magazines and rifle(s)"

Purpose of change

A new magazine type as well as a new rifle to support it. Changed the name of the 552 to 553 as both of the variants are about the same (553 being an upgrade to 552).

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Not sure if the makeshift SIG SG magazine is needed with the item probabilities (not for me to decide but anyway) being so low.

[tenmillimaster]

Please add entries for the new gun and magazines to generic guns' migrations. (/data/mods/generic guns)
I don't believe there's any need to change the ID of sig552 to sig553, but if really needed, you'll also need to add a migration entry in the main game.

Volume analysis:
For the sg550:
Length of rifle: 998mm Width of rifle used (37.3564mm)
Width: 56mm(width of this B+T handguard)- (minimum height of two picatinny rails)

Volume: 74812.984 square mm * 37.3564 mm = ~2795 mL.

For the sg553:
Length of rifle: 730mm Width of rifle used (37.3564mm, see above)

Volume: 57762.957 square mm * 37.3564mm = ~ 2158 mL

The SG550 doesn't need a damage penalty(so it's ranged damage should be 0), and the 553 should get a -6.

None of the SG55x rifles belong in the military item groups.

[SnowFreeTrack]

@tenmillimaster Great way to measure volume! I'll start using it from now on, perhaps even fix some other firearms while I'm at it. Also, that's a handy spreadsheet for damage calculation. Is it available somewhere? Or is it your patented formula?

[tenmillimaster]

Any ball ammunition is defined as doing the square root of its muzzle energy of damage. I just adapted
work from Dr. Phillip Dater of Gemtech Suppressors. I just select whichever regression works best for the graph, forcing an y intercept of 0 (r value as close as possible to 1) and call it good enough.

The program to get the 'area' of a gun's profile is imagej, you just need a good picture of it and a known length. Width is usually trickier.

Note, you still need to update the migration in /data/json/items? to swap out all of the 552's for 553's. You should also consider removing some of the slots on the sigs, since they don't come standard with siderails or optic rails.

[SnowFreeTrack]

@tenmillimaster You read my mind! I was just thinking about the slots. I replaced the 552 in Generic gun mod and either I'm blind (which might as well be the case) or there are no other 552's left. Also, while on the subject of volume, it is actually possible to make an approximate calculation of the area using Photoshop or Gimp, which could be useful for future volume correction or calculation.

[tenmillimaster]

People's old saves will still reference sig552, hence the migration to replace them with the new ID.

[ZhilkinSerg]

Feel free to resolve conflicts and reopen if you feel working on it again.