Use stairs above or below when they exist #38244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
force-pushed
the
stairs
branch
3 times, most recently
from
89510f8 to
ed49c34
Compare
ZhilkinSerg
added
<Bugfix>
Sometimes when you went down stairs in close proximity, it could move you to a different set of stairs - this is most visible in evac shelter 0 and 2, where going down the top left stairs could teleport you to the bottom right stairs. To fix this, if there are stairs below or above the stairs you're using, go directly to those instead of searching the map for stairs.
anothersimulacrum
force-pushed
the
stairs
branch
from
f7cd21b to
7141f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Seen in #36833 (comment)
Sometimes when you went down stairs in close proximity, it could move you to a different set of stairs - this is most visible in evac shelter and evac shelter 2, where going down the top left stairs could teleport you to the bottom right stairs.
Describe the solution
To fix this, if there are stairs below or above the stairs you're using, go directly to those instead of searching the map for stairs.
Testing
Go to evac shelter or evac shelter 2, and go down the top left of the 2x2 set of stairs. Before, going down and then up would move you to the bottom right set of stairs. Now, it leaves you on the same stairs.
Additional context
The only place that the weird behavior in #36833 will be seen after this will be when there are non-aligned stairs, which I think should be considered a bug.