Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add purse to bride and ballroom dancer professions #38223

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

jkraybill
Copy link
Contributor

Summary

SUMMARY: Content "Add purse to bride and ballroom dancer professions"

Purpose of change

Fixes #38207

To prevent items from dropping to the ground as soon as you start with the female ballroom dancer or bride professions, added purse to the starting inventory.

Describe the solution

These professions now start with a purse in the female version.

Describe alternatives you've considered

I considered either making dresses store a small amount (0.5L), but this seemed potentially controversial based on the original issue's discussion thread. It seems reasonable that dresses can store 0.5L even if they don't have pockets.

The purse in the game stores 5L; for starting inventory, this seems maybe slightly OP compared to the tux which stores 2L. A better solution may be to add a "small purse" that stores 2L, but I didn't want to add a new item this close to release. I think that's a better long-term solution after release though.

Testing

Ran starts with maid, ballroom dancer, and bride before the change. Ballroom dancer and bride inventory tumbled to the floor.

Ran start after the change. The items remained in inventory.

Additional context

I think it's worth reconsidering modifying dresses, or adding a small purse, but both seemed a little extreme at this stage in the release.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Feb 22, 2020
@ZhilkinSerg ZhilkinSerg merged commit a70217c into CleverRaven:master Feb 22, 2020
@jkraybill jkraybill deleted the 38207 branch February 22, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ballroom dancer's lack of pockets
2 participants