JSONize AEP_EVIL and implement intermittent artifact effects #38221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
<Enhancement / Feature>
KorGgenT
force-pushed
the
artifact-intermittent
branch
from
d62e27f to
c6acd3e
Compare
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 16, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 18, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 29, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "JSONize AEP_EVIL and implement intermittent artifact effects"Purpose of change
Part of the artifact rewrite project and #38193
Describe the solution
Implements AEP_EVIL in json (see game.cpp, game::process_artifacts())
this required some debugging intermittent_effects, as there was an issue with the save/load for it. AEP_EVIL just adds the "evil" effect on you for 30 minutes, and adds a flavor message. i chose to leave out the message for now.
Testing
I tested it in game with magiclysm and the summon zombie spell to make sure intermittent effects happened properly.
Additional context
this makes it possible to do a bunch of those effects in json only!