Update type of 22_casing_new #38172
Merged
Update type of 22_casing_new #38172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove fields relating to ammo. tested changes by disassembling .22 ammo into this casing, then crafting reloaded ammo
ZhilkinSerg
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Update type of 22_casing_new"Purpose of change
Fixes a migration error with Generic Guns.
Any world which attempts to load with Generic Guns active will get:
ERROR : src/item_factory.cpp:629 [void Item_factory::finalize_item_blacklist()] Replacement item pistol_tiny_casing for migrated ammo 22_casing_new is not ammo.Describe the solution
Change the
22_casing_newfrom type ofammotogeneric, then move it into casing.json with the other casings.Describe alternatives you've considered
None
Testing
Loaded into world with Generic Guns active.
Additional context
This error was observed when compiling with commits up to the merge of #37746.