Allow multiple overmap terrains in start location

[ZhilkinSerg]

Summary

SUMMARY: Infrastructure "Allow multiple overmap terrains in start location"

Purpose of change

Allow multiple overmap terrains in start location without cluttering UI for each distinct terrain.

Describe the solution

Code was changed to allow multiple terrains be defined for start locations, they all would occupy a single line in UI and be selected randomly on game start. From players perspective this would allow players to start in any house type instead of only 6 predefined houses. Thanks to overmap match type support it is still possible to create a mod that allow starting in specific terrains.

Screenshot:

Syntax:

  {
    "type": "start_location",
    "id": "sloc_police",
    "name": "Police Station",
    "terrain": [ { "om_terrain": "police", "om_terrain_match_type": "PREFIX" } ]
  },
  {
    "type": "start_location",
    "id": "sloc_restaraunt_foodplace_break_room",
    "name": "Foodplace Break Room",
    "terrain": [ "s_restaurant_foodplace_roof" ]
  },
  {
    "type": "start_location",
    "id": "sloc_school",
    "name": "School",
    "terrain": [ { "om_terrain": "school", "om_terrain_match_type": "CONTAINS" } ]
  },
  {
    "type": "start_location",
    "id": "sloc_campground",
    "name": "Campground",
    "terrain": [ "campground_1a", "campground_1b", "campground_2a", "campground_2b" ]
  },

I've also updated names of some start locations for consistency.

Testing

Try various scenarios and see that player character is put to correct start locations.

Additional context

1. I've updated start locations and scenarios in all in-repo mods, but it could possibly break third party mods that add/expand start locations. These mods need to use new syntax:

• replace target string node with terrain array node (e.g. "target": "s_bunker_shop_g" -> "terrain": [ "s_bunker_shop_g" ] );
• optionally utilize overmap terrain match type nodes (e.g. "terrain": [ { "om_terrain": "house", "om_terrain_match_type": "PREFIX" } ] to reduce UI cluttering).

2. We would probably like to cleanup and expand start locations using new syntax in later PRs (as current PR could possibly allow spawning players in undesired location - e.g. house roof).

[AMurkin]

Could the first option of that list be a Random location? (Looking at the #38110)

[ZhilkinSerg]

Could the first option of that list be a Random location? (Looking at the #38110)

Sure. It is unrelated though and can be done in a separate PR.

[ZhilkinSerg]

Could the first option of that list be a Random location? (Looking at the #38110)

It was done in #38544.

[ZhilkinSerg]

There is a strange bug I cannot grok by myself:

When you select Evacuee scenario (only it as far as I see) you cannot select a second entry in starting location selection menu.

Also in this scenario starting location defaults to this second entry (shelter), while in other scenarios it correctly defaults to first entry (random location).

Okay, that is actually something from #38544, so it should be fixed separately.