house palette tweak

[LilShiningMan]

Summary

SUMMARY: Infrastructure "minor changes to make palette more versatile"

Purpose of change

To make the standard house palette more versatile and less cluttered. Issues I've noticed: 1) standard palette overrides " " in map files with "t_floor", which is only useful if your fill_ter is t_floor -- otherwise you need to override the override in each file; 2) woodstove is duplicated, the second time without associated items; 3) a shredder sometimes spawns in lieu of a filing cabinet -- while intentional, it doesn't make sense for items like dice or liquor flasks to spawn in a shredder (office_paper item group), and with the spawn rate of 80 filing cabinet to 20 shredder, it's such a rare occurrence for the shredder to appear that you might as well intentionally definite it in each map on an as-needed basis.

Describe the solution

1. changed " " from t_floor to t_null. That's the easiest way I know to make the tile default to the fill_ter defined in each map. If there's a better way, please let me know!
2. deleted "0": "f_woodstove" and listed the "0" in unclaimed symbols in file comment line.
3. removed the shredder from the "P" definition.

Describe alternatives you've considered

creating my own palette override for houses I design, but this makes more sense to me.

Testing

spawned some houses in-game.

Additional context

I may be missing something, and so I'd like some of the regular house designers to weigh in here.

[I-am-Erk]

You shouldn't need to define " " at all if you want it to generate fill_ter. I'm not certain but I think specifying it as null could confuse nested mapgen.

[curstwist]

I'm ok with the removal of the shredder and the duplicate entry. I'm not sure if making " " t_null will have unintended consequences for nested mapgen. Erk says it doesn't matter if removed entirely so I'd trust that opinion.

[LilShiningMan]

I could be wrong, but my understanding was that house_w_palette was for the nested house mapgens, but I take your point. I'll remove the " " definition entirely.

[curstwist]

there's nothing stopping someone from using any palette for nested mapgen, so better safe then sorry. I can't remember if I've used it there off-hand.