Update tileset compose colorspace handling #37818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
libvips, used by the tileset compose script, assumes that all files are in the same colorspace. When they're not, it causes issues when they're all composed together.
Describe the solution
Check for an ICC profile, and if it's there, use it to transform the image into sRGB colorspace that libvips assumes images are in.
Describe alternatives you've considered
We could have the script check for this and just complain instead of fix it, but we've generally tried to make it more accepting if it can handle the issue (much as was done for the requirement to have an alpha channel). We can always have it complain in the future.
Testing
Ran the compose both before and after and noted that the sprites missing colors in the before had it in the after.
before
after