Display appropriate item values with less precision #37812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volume to three decimals. Everything else to what makes sense
Delete my bat for compiling
Restore rounding up and set to thousandths place, for extremely low volume items.
ifreund
added
<Bugfix>
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Display appropriate item values with less precision"Purpose of change
Fixes #37781.
Followup #37744.
Describe the solution
Create a new flag for thousandths level of precision.
Apply it to item volume.
Change volume rounding up from tenths to thousandths.
Describe alternatives you've considered
Leaving weight at three decimals, but I don't think it's reasonable that the player can determine weight that accurately through normal observation.
Testing
Compile, load game, spawn a stack of 10 caffeine pills.
Additional context
Before (on stack of 10 pills)
After