Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comestible modern json #37793

Merged
merged 3 commits into from
Feb 7, 2020
Merged

Comestible modern json #37793

merged 3 commits into from
Feb 7, 2020

Conversation

snipercup
Copy link
Contributor

Summary

SUMMARY: none

Purpose of change

Contributes to #36110 and #36610

Describe the solution

Change name to object
remove name_plural
only add str_pl if it does not just add a s
change flags to an array
fix a looks_like to point to a valid id

Describe alternatives you've considered

not changing

Testing

image
image
image

@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Feb 7, 2020
@ZhilkinSerg ZhilkinSerg merged commit 999937b into CleverRaven:master Feb 7, 2020
@snipercup snipercup deleted the Comestible-modern-json branch February 9, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants