Check if entire pane is liquid items before allowing moving all in AIM #37776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
reviewed
Feb 6, 2020
Co-Authored-By: Isaac Freund <[email protected]>
Co-Authored-By: Isaac Freund <[email protected]>
ZhilkinSerg
added
<Bugfix>
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Check if entire pane is liquid items before allowing moving all in AIM"Purpose of change
Fixes #33962
Describe the solution
Add check that the entire list of items in the pane can be moved before moving all.
The AIM currently checks if its liquid when you select one item to move, or when there is more than one item, and you select move all, but not when you select move all on just one item that is liquid.
Describe alternatives you've considered
N/A
Testing
before fix - dropped water on floor, opened AIM, tried to move it with , key to move all. it turned into a zero-charge weird item, then subsequent attempts to move it, caused a crash.
After fix - cannot "move all" when its a liquid item.
Additional context
N/A