Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor/comestible modern json #37675

Merged
merged 4 commits into from
Feb 3, 2020
Merged

Armor/comestible modern json #37675

merged 4 commits into from
Feb 3, 2020

Conversation

snipercup
Copy link
Contributor

@snipercup snipercup commented Feb 3, 2020

Summary

SUMMARY: Content "Update name format, give volume to jewelry."

Purpose of change

Contributes to #36611 and #36110

Describe the solution

Change name string to object
Change volume int to string
Doubles now have a decimal

Describe alternatives you've considered

Not changing

Testing

image

image

image

@snipercup snipercup marked this pull request as ready for review February 3, 2020 18:20
@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Feb 3, 2020
@ZhilkinSerg ZhilkinSerg merged commit 0324844 into CleverRaven:master Feb 3, 2020
@snipercup snipercup deleted the Armr-modern-json branch February 5, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants