Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Armor.json sorting pt. 7 #37505

Merged
merged 5 commits into from
Jan 29, 2020
Merged

Armor.json sorting pt. 7 #37505

merged 5 commits into from
Jan 29, 2020

Conversation

RarkGrames
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Sorted items out of armor.json into separate files"

Purpose of change

Sorting out armor.json for easier handling.
Continuation of #37468.

Describe the solution

  • Sorting applicable items to arms_armor.json, scarfs.json, legs_clothes.json, legs_armor.json and misc.json.
  • Merging arm_guards.json and leg_guards.json into arms_armor.json and legs_armor.json.
  • Deleting armor.json.

Testing

Game loads properly, line counts check out.

@Brian-Otten
Copy link
Contributor

After having to sort through armor.json once too many recently i'm a big fan of this PR.

@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Jan 29, 2020
@ZhilkinSerg ZhilkinSerg merged commit 1302f17 into CleverRaven:master Jan 29, 2020
@RarkGrames RarkGrames deleted the Armor.json-sorting-pt.-7 branch January 29, 2020 14:34
@weekly-digest weekly-digest bot mentioned this pull request Feb 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RarkGrames @Brian-Otten @ZhilkinSerg