Cable charger CBM don't draw power when you're full #37290
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
This was referenced Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Cable charger CBM don't draw power when you're full"Purpose of change
Cable charger CBM don't draw power when you're full.
I'm pretty sure a cable connecting a power source to a full battery will not draw power from the power source.
Describe the solution
If power bank are full don't consume remote fuel
Describe alternatives you've considered
Testing
Compile without error
Get Cable Charger CBM
Plug to UPS
Disable fuel saving mode
Wait
Power banks reach max
Keep waiting
UPS charges don't go down
Repeat with vehicle
Power goes up to max
Keep waiting
No power consumed from vehicle
Additional context
This is on top of fuel saving mode, if you turn the mod off and keep the cable cahrger on you will still not waste power.
Maybe I should remove code to support fuel saving mode on the cable charger in favour of that?