House fix #37261
Merged
House fix #37261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curstwist
added
<Bugfix>
be kind, fix the weight.
|
This also includes a new definition for house_wooded? |
This was referenced Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix house from spawning too frequently, include mapgen support for legacy mod houses."Purpose of change
The house I had set to "house" was spawning too frequently due to its regional settings and a specials entry.
Describe the solution
I've renamed the house I had assigned to ID "house" and created an empty field placeholder for mods that still use the fake special "house" instead of being defined as specials.
I've also added the rare basement spawns in the regional_settings city list, so I think they should show up more.they don't and have been removed.Describe alternatives you've considered
breaking all the houses in mods
Testing
Loaded up the game and made sure I didn't trigger load errors, made sure my house wasn't spawning too frequently.