Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sports drink recipe #37256

Closed
wants to merge 3 commits into from
Closed

Conversation

Inglonias
Copy link
Contributor

@Inglonias Inglonias commented Jan 20, 2020

Summary

SUMMARY: Content "Added recipe for sports drink"

Purpose of change

I wanted to be able to craft sports drinks.

Describe the solution

I'm assuming that the sports drink in the game resembles Gatorade or one of its competitors in real life. Those drinks are based on a concept called Oral Rehydration Therapy, and the recipe for that is dead simple. It's not common knowledge, though, so I didn't want the recipe to be learned automatically, and put it into a chemistry textbook. The recipe should also be found in first aid manuals, as this is a dead simple remedy for dehydration.

Describe alternatives you've considered

N/A

Testing

Checked that the recipe works as described and that the game didn't crash. Did the math on the ratios, as they do need to be correct, or else this drink makes things worse.

Additional context

Based on the math used in game, a single portion of salt is 5 grams. A teaspoon of salt is about the same mass, and you need half of a teaspoon per liter of water. As a result, you can't make less than two liters with the portions in-game.

It makes sense that you'd be able to learn about ORT solution from a first aid manual.
@Inglonias
Copy link
Contributor Author

Here's another source to use. (The book is Ryan North's How to Invent Everything)

image

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks labels Jan 20, 2020
@I-am-Erk
Copy link
Member

Sports drink and oral rehydration therapy are quite different, even if ort was the inspiration. I'd love to have ort in game though.

@Inglonias
Copy link
Contributor Author

Inglonias commented Jan 21, 2020

Would that be as simple as making a new "rehydration drink" which has quench 60 but a lower joy value than sports drink?

@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 21, 2020

Yep. ORT is kinda nasty tasting, it's way less sugary than sports drink. Sports drink would probably be better simulated by mixing soda pop or sugary juice with salt and bicarbonate.

@Inglonias
Copy link
Contributor Author

I'll make the change when I get some tine tomorrow. Thank you for the feedback.

"skill_used": "cooking",
"time": "3 m",
"charges": 8,
"autolearn": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify "autolearn" being false for recipes; it's the default value (that is, if you don't specify "autolearn" being true).

@Inglonias
Copy link
Contributor Author

Closing to allow refactoring as per comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants