Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create string_consts.h and pull string consts from player.cpp and character.cpp #37231

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Jan 19, 2020

Summary

SUMMARY: Infrastructure "Create string_consts.h and pull string consts from player.cpp and character.cpp"

Purpose of change

Having the various string consts copied all over the place is really annoying and potentially error prone. This is the start of creating a single file to contain organize and possibly eventually comment on them.

Describe the solution

Created file string_consts.h, then removed all string consts from player.cpp and character.cpp and combined and alphabetically sorted them.

Describe alternatives you've considered

Testing

Additional context

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Jan 20, 2020
@jbytheway
Copy link
Contributor

If these are in a header then they should probably no longer be marked static. I suspect clang-tidy would have complained about that, but it didn't get a chance to run in this PR's Travis run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants