Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three new map extras #37160

Merged
merged 14 commits into from
Jan 20, 2020
Merged

Three new map extras #37160

merged 14 commits into from
Jan 20, 2020

Conversation

RarkGrames
Copy link
Contributor

Summary

SUMMARY: Content "Added 3 new map extras"

Purpose of change

Adding three new map extras.

Describe the solution

prison bus 03
Prison bus verson 1

prison bus 02
Prison bus version 2

prison bus
Prison bus version 3

wasp
Wasp nest

dermatik
Dermatik nest

Testing

Spawned all of them to see if everything is correct.

@curstwist curstwist added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jan 18, 2020
@RarkGrames
Copy link
Contributor Author

Are they going to spawn with the same chance?

@ZhilkinSerg
Copy link
Contributor

ZhilkinSerg commented Jan 19, 2020

Are they going to spawn with the same chance?

I am pretty sure we only support only a single update_mapgen function with a given id.

@RarkGrames
Copy link
Contributor Author

I encountered all three version of it while testing, so it seemed to me that it was working.

@ZhilkinSerg
Copy link
Contributor

I encountered all three version of it while testing, so it seemed to me that it was working.

Then each entry must have the same default weight.

@RarkGrames
Copy link
Contributor Author

Ok, I don't think it's a problem for them to be not weighted, they are not that different.

@ZhilkinSerg
Copy link
Contributor

You can change them unique ids and control weight via map extras, but we should probably just add weights for nested/update_mapgens in the future.

@RarkGrames
Copy link
Contributor Author

RarkGrames commented Jan 19, 2020

It can wait until the update_mapgen gets weights. After all that will be more similar to how overmap mapgen works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants