Magazine Item Group Revamp #37141
Merged
Magazine Item Group Revamp #37141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overhauled magazine item group -- added magazine categories, removed novels and misc books
cainiaowu
reviewed
Jan 18, 2020
data/json/itemgroups/mansion.json
Outdated
| { "group": "tobacco_products", "prob": 50 }, | ||
| [ "novel_pulp", 30 ], |
There was a problem hiding this comment.
This file need to be linted.
There was a problem hiding this comment.
Thanks. I delinted the files originally but had to make changes after making the PR and did not re-lint.
ZhilkinSerg
added
Items / Item Actions / Item Qualities
This was referenced Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "overhauled magazine item group -- added magazine categories, removed novels and misc books"Purpose of change
Item groups streamlining and tidying. This was a particularly messy item group which added a lot of novels and other random items, all of which belong in their own categories.
Describe the solution
Removed novels and other miscellaneous books from item group, defined various magazines in topical subgroups, called all subgroups in main magazine list.
Describe alternatives you've considered
Testing
linted and then debug spawned main list and all subgroups in game.
Additional context
I moved the atomic_survival book to the homebooks group to preserve it's lost spawn chance. I moved trailmap to the livingroom group, which should more than make up for it being removed from the magazines spawn group.
Breaking this group up into discreet subgroups and then replacing redundant spawn lists in the various .jsons by calling the groups saved somewhere in the neighborhood of 190 lines of text.