MP3 Cellphone Battery Hammerspace Fix

[Xanmyral]

Summary

SUMMARY: Balance "Resolve MP3&Cellphone Battery Hammerspace Issue"

Purpose of change

MP3 Players and Cellphones have a magazine_well of 1 which gives them (around) 0.25L of internal storage (despite being much smaller than this). This shows in the game as the 0.05L MP3 Player able to have the Light Battery (High Capacity), which is 0.12L, loaded into it and the grand result is a 0.05L MP3 Player with said battery that is larger than the MP3 itself. Cellphone has this same issue, but to a more minor extent.

Describe the solution

• Increased the size of the cellphone to 0.13L (larger flip-phone) to minimize hammerspace issue.
• Removed light batteries from being loaded into the MP3 Player, restricted to only ultra-light batteries (technically a nerf).

Describe alternatives you've considered

A more satisfactory change might be to batteries themselves as they're rather sizable (a High Capacity Light Battery is just shy of a meat cleaver in terms of volume?), but since this issue is only present on two items I figured the smaller change would be better for now.

Removing the magazine_well might also have worked, but I believe that to be a stranger fix as it would imply the batteries aren't internal by any extent.

Increasing the granularity of magazine_well might also have done it, but that would have been a far reaching change.

Testing

Loaded in, debugged about a hundred zombies and debug killed them.
Looked at all of their drops, confirmed cellphone was 0.13L and wasn't changed beyond that.
Confirmed that MP3s spawn properly with Ultralight batteries on drops without additional changes.

[ZhilkinSerg]

You probably need to lint modified file.

[ghost]

Why not reduce the battery volumes? They're very big relative to real life at the moment.

Ex. a triple A battery per this product datasheet should be:

(1.05 cm diameter/2)^2*pi * 4.45cm height ~ 4(3.853)ml.

[Xanmyral]

I wouldn't say no to reducing the battery volumes, honestly. If that isn't minded I could just slash battery volumes in half for most (or likely reduce further, I'd have to look at actual battery volumes but light batteries I would peg at about 0.05 to 0.03 personally before doing actual comparisons), because to be honest they're rather large.

I figured the smaller change for the smaller problem would be more acceptable.

[Xanmyral]

I'll close this for now and instead look at changing battery volumes.