Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drawing artifacts in some inventory menus #37125

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Fix drawing artifacts in some inventory menus #37125

merged 1 commit into from
Jan 17, 2020

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Jan 16, 2020 •
edited
Loading

Summary

SUMMARY: None

Purpose of change

Fix drawing artifacts in some inventory menus.

Describe the solution

Add refresh in inventory menus (consume, drop, etc).

Testing

  1. Have some consumables in character inventory.
  2. Open consume menu.
  3. Consume some items, so list would be 1 item shorter.
  4. See that underlying windows (old menu, map and side panel) are refreshed and no artifacts are visible.

Additional context

Before

image

image

After

image

image

@ZhilkinSerg ZhilkinSerg added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Jan 16, 2020
@kevingranade kevingranade merged commit 63de6f0 into CleverRaven:master Jan 17, 2020
@ZhilkinSerg ZhilkinSerg deleted the fix-redraw-2020-01-16 branch January 17, 2020 08:03
@ghost
Copy link

ghost commented Jan 17, 2020

this probably also close #36418

@ghost ghost mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhilkinSerg @kevingranade