Stop Hulks teleporting after shoving vehicle. #37117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
va5h
added a commit
to va5h/Cataclysm-DDA
that referenced
this pull request
Jan 17, 2020
ghost
deleted the
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Stop Hulks teleporting after shoving vehicle."Purpose of change
Fixes #36190
Describe the solution
The shove_vehicle() function can trigger a submap shift, if the player is in the vehicle when it moves, then the rest of monster::move() can carry on using a local position it stored beforehand, to move to.
So ive just changed that to store absolute position, then convert it to local after shove_vehicle, when it comes time to actually move there.
That way any submap shifting wont invalidate that position.
Describe alternatives you've considered
N/A
Testing
Loaded save in linked issue, hulk didnt teleport.
Spawned a few mothe rmonsters and moved around to make sure monster movement in general wasnt broken by this change.
Additional context
N/A