Refactor closest_(tri)points_first functions
#37108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved into `point` file; - rearranged function parameters; - removed duplicate code; - get rid of some `auto` and one time use variables;
ZhilkinSerg
added
Code: Tests
jbytheway
reviewed
Jan 17, 2020
src/point.h
Outdated
| * Following functions return points in a spiral pattern starting at center_x/center_y until it hits the radius. Clockwise fashion. | ||
| * Credit to Tom J Nowell; http://stackoverflow.com/a/1555236/1269969 | ||
| */ | ||
| std::vector<tripoint> closest_tripoints_first( const tripoint ¢er, size_t radius ); |
There was a problem hiding this comment.
This needs to be inside the #ifndef CATA_NO_STL region to avoid the clang-tidy errors you're seeing (because the clang-tidy test files include this file but don't get to use the STL, so e.g. no std::vector).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Refactor
closest_(tri)points_firstfunctionsDescribe the solution
pointfile;radius, center->center, radius);autoand one time use variables;Testing
Purely technical refactor. There are should be no effect on gameplay. Just make sure game and tests compile and run.