Martial Arts missing Learn Diffculty and Incorrect Bonuses #36772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Medieval Swordsmanship and Leopard Stance were missing the learn difficulty, making them potentially easier to learn than intended. Leopard stance's on move buff gave a flat bonus to damage instead of the intended multiplier. Eskrima stance was giving a 200% bonus to accuracy instead of the intended +2 accuracy.
ZhilkinSerg
added
<Bugfix>
|
I just realized that Fior Di Battaglia and Medieval Swordsmanship lack primary_skill, thus meaning learning them is based on unarmed. |
Fior Di Battaglia uses bashing skill, Medieval Swordsmanship uses cutting skill
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes martial arts missing learn difficulties and incorrect bonus types"Purpose of change
Fixes #36461 - Leopard Kung Fu gives incorrect bonus and a few other related issues I found:
First two can be seen plainly when viewing the martial art style with F1, last two are missing in the JSON. Debug spawn in the books for both and you'll see both are noted as "Easy to Learn" and you can learn both with 0 unarmed in under an hour.
Describe the solution
Changed the flat bonus to mult for leopard, mult to flat for eskrima, and added on learn difficulties for Leopard (same as other shaolin styles) and Medieval (arbitrarily picked Fior Di Battaglia)
Testing
Spawned in both books and attempted to learn them within the day like prior. Took until 8 PM from start to learn Medieval. Could not learn Leopard in time before night fall. Both were called hard to learn and extremely hard to learn for medieval and leopard respectively.
Gave all martial arts, viewed the F1 and confirmed the values were a flat bonus for Eskrima and a multiplier for Leopard
Additional Context