Overhaul anthill generation to avoid conflicting with other map features #36767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
After the recent changes to keep anthills from conflicting with other terrain, #36736 #36702
Anthills would occasionally fail to generate due to colliding with other map features.
One failure was fatal since no tiles were placed.
Another resulted in labs overwriting pieces of anthills.
Fixes #27726
Describe the solution
Moved anthill generation after all other map features since they were conflicting with pre-cataclysm structures so anthills should never prevent construction of other structures.
Restructured anthill generation to not place features piecemeal.
Checked that the level under an anthill is clear before placing the anthill and associated resources.
Reset anthill if it is unable to be placed.
Testing
There was a fairly consistent failure that triggered in testing.
Also teleport across multiple overmaps and look for poorly generated anthills.