Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds military helipad location #36732

Merged
merged 8 commits into from
Jan 8, 2020
Merged

Conversation

CountAlex
Copy link
Contributor

@CountAlex CountAlex commented Jan 5, 2020

Summary

SUMMARY: Content "Adds new mapgen location - military helipad"

Purpose of change

New location.

Describe the solution

This is small military helicopter pad outpost. Nothing like full-scale helicopter base (those are rare) or something like that.
Just a small military location with 3 pads, hangar, barracks and some guarding turrets.

Testing

Main level - pads, offices, cantina, warehouse, parking lot and entrance.
main

2nd level - barracks and roofs.
roof

Additional context

I will add screenshots so people might have a better look.
This also adds outdoor version of yellow concrete so pads can be accented.

@curstwist curstwist added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jan 6, 2020
@curstwist
Copy link
Contributor

screenshots please.

@Amoebka
Copy link
Contributor

Amoebka commented Jan 6, 2020

This should probably have a single-frame crane vehicle instead of the guaranteed lifter mech. Those are rare prototypes, not standart issue equipment for small military installations.

@CountAlex
Copy link
Contributor Author

CountAlex commented Jan 6, 2020

screenshots please.

Let me weed out errors, and I will throw them in.

This should probably have a single-frame crane vehicle instead of the guaranteed lifter mech. Those are rare prototypes, not standart issue equipment for small military installations.

Then I will figure something out. Forklift car might be a good solution.

Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too would like screenshots.

Not too many overall changes needed on this I don't think. Looking forward to merging.

data/json/mapgen_palettes/helipad.json Outdated Show resolved Hide resolved
data/json/mapgen_palettes/helipad.json Outdated Show resolved Hide resolved
"items": {
"B": {
"item": {
"subtype": "distribution",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like something that could be defined in an itemgroup, perhaps in supplies.json. I can see other people having use for drums of gasoline and motor oil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it as you suggested. I will give it some test about spawned amounts - I am not sure how charges work with fuels exactly. Besides I'd like to have some opinion on how much fuel spawned barrels should have.
I also think motor oil might need to have different container than plastic jerrycan.

data/json/mapgen/helipad.json Outdated Show resolved Hide resolved
@CountAlex
Copy link
Contributor Author

Cleaned up some things and added screenshots.
Also moved copters spawning points a bit and decreased chance of them spawning since they spawn way too intact without making it hardcoded as it works for map extras.

@Amoebka
Copy link
Contributor

Amoebka commented Jan 7, 2020

10 turrets is 16.000 rounds of 5.56 a player can loot from one location.
Just saying.

@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 7, 2020

The ammo loot isn't really a consideration when designing a map. That's a problem with calculating turret age, not mapgen.

@Amoebka
Copy link
Contributor

Amoebka commented Jan 7, 2020

Yes, but mapgen can still take it into account if there are no downsides.

10 turrets don't exactly guard the location any better than 4. Gameplay-wise turrets are gear checks, and a player that can deal with 4 turrets can just as easily deal with 10, the only difference being the ammo reward. Story-wise, this is a small refueling base deep inside home territory, it doesn't need multiple machinegun nests with overlapping firing arcs. A few turrets would do just fine to deter theoretical terrorists and random idiots.

For reference, this is more security than what military bunkers, military outposts and nuclear missile silos have in game.

@CountAlex
Copy link
Contributor Author

Changing amount of turrets will take me two minutes while this is still at PR stage. Just tell me if I need to.

@Amoebka
Copy link
Contributor

Amoebka commented Jan 7, 2020

I would say leave just the 4 turrets in the corners. Their ranges should be high enough to cover the entire perimeter anyway.

@CountAlex
Copy link
Contributor Author

Yeah, I guess it makes sense. Missile silo also has only corner ones (and couple near entrance) while being way more significant military object.

@I-am-Erk I-am-Erk merged commit 89ef868 into CleverRaven:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants