Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate houses 06-10 #36693

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Conversation

curstwist
Copy link
Contributor

Summary

SUMMARY: Content "Add roof and renovate houses 06-10."

Purpose of change

Continue house rehab project.

Describe the solution

Converted houses to the standard_domestic_palette.
Minor renovations to add new furniture, basement stairs.
Added roofs (some share a roof due to identical foundations)

Describe alternatives you've considered

Breaking these up in more PR's. I think this is a reviewable amount though since they are all getting standardized. Let me know what reviewers prefer for future PRs.

Testing

Lots of spawning in the world.

Additional context

In general if the original mapgen offers a unique loot, I've tried to preserve that.

I have added guns to the palette's safes and most household guns will now spawn in safes, I have left a few chances in some of their old locations though. A new lockable gun cabinet furniture piece would be welcome if someone would like to make it :).

house 06: uses 04's roof.
house06 before
house06 after

house 07: uses 04's roof
house 07 before
house 07 after

house 08:
house 08 before
house 08 after
house 08 roof

house 09:
house 09 before
house 9 after
house 9 roof

house 10: sorry forgot to take a before shot.
house 10 after
house 10 roof

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jan 4, 2020
@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 4, 2020

If house6 uses house4's roof, maybe just name it house4 and then the generator will randomly select one of the two whenever a house4 spawns?

@curstwist
Copy link
Contributor Author

If house6 uses house4's roof, maybe just name it house4 and then the generator will randomly select one of the two whenever a house4 spawns?

I'd prefer to keep unique id's to make regional weights easier to manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants