Fix monsters not being spawned on the map #36691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
(P2 - High)
|
On second thought it is possible that we will use (or already are using) this function to spawn monsters on a different non-game map, so I should not move these checks out of their place. |
|
Thank you! I wondered what the hell was going on 😁 😁 |
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Fixes #36690
Describe the solution
2. Move some checks on top of the function to bail out early when possible (should increase performance a bit).Describe alternatives you've considered
Play in a monster-free world!
Testing
Start a new game (or visit new overmap terrain tiles) and see that new monster are being spawned again.