Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs related to interacting with bucket-type containers #36681

Merged

Conversation

HoussemFerjaoui
Copy link
Contributor

@HoussemFerjaoui HoussemFerjaoui commented Jan 4, 2020

Summary

SUMMARY: Bugfixes "fix bugs related to interacting with bucket-type containers"

Purpose of change

Fixes #36597
Fixes #36680

Describe the solution

add a condition to check that the item being used dosnt have a use_action before directly consuming it.

Describe alternatives you've considered

N/A

Testing

spawned stock pot with clean water and heated it up correctly
consumed hot clean water contained in stock pot
no crashes or duplicates when canceling consumption
when not near a fire source consuming water contained in the stock pot wont happen directly & info msg displays correctly

Additional context

N/A

#Summary

SUMMARY: Bugfixes "fix bugs related to interacting with bucket-type containers"

#purpose of change

fixes CleverRaven#36597 and 36680

#describe the solution

add a condition to check that the item being used dosnt have a use_action before directly consuming it.

#Describe alternatives you've considered

None.
@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 6, 2020
@kevingranade kevingranade merged commit 1d7960f into CleverRaven:master Jan 12, 2020
@HoussemFerjaoui HoussemFerjaoui deleted the foodcontainersactionfix branch January 12, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
3 participants