Fix garage door knockback crash #36671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind, this was just tested by anothersimulacrum who can repro the crash reliably, and its still crashing for them. |
ghost
closed this
ghost
reopened this
|
Reopened as @anothersimulacrum has been assisting me with finding the real problem here for the real fix. |
anothersimulacrum
approved these changes
Jan 3, 2020
ZhilkinSerg
added
<Bugfix>
|
This has a teensy bug, it'll now prefer flinging in specific directions instead of it being random. |
|
Take a look at random_point() for how to pick a random point filtered by criteria. |
|
yup, added that now. |
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix garage door knockback crash"Purpose of change
Fixes #34963
Describe the solution
knockback() was passed two points from from
forced_door_closing()though in some circumstances, that could pass two identical points, which caused crashes in slope_from() in line.cpp.Used points_in_radius() instead of the previous rng method, and added checking for two identical points.
Describe alternatives you've considered
N/A
Testing
I cant actually reproduce the issue myself, but anothersimulacrum and others have been able to and they have tested this change.
Additional context
N/A