-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended shift-v items menu #36663
Merged
kevingranade
merged 15 commits into
CleverRaven:master
from
8street:Extended-shift-v-menu
Apr 2, 2020
Merged
Extended shift-v items menu #36663
kevingranade
merged 15 commits into
CleverRaven:master
from
8street:Extended-shift-v-menu
Apr 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update forked repo
Update forked repo
Update forked repo
how does this look with minimum screen size |
BevapDin
reviewed
Jan 3, 2020
tests start
This was referenced Jan 5, 2020
Update fork
curstwist
added
Info / User Interface
Game - player communication, menus, etc.
[C++]
Changes (can be) made in C++. Previously named `Code`
labels
Jan 6, 2020
I'd resolved conflicts. Can be merged. Also PR fixes #36787: width of the list_items was also hardcoded in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[C++]
Changes (can be) made in C++. Previously named `Code`
Info / User Interface
Game - player communication, menus, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Extended shift-v items menu"
Purpose of change
If a player is looking around (shift-v items menu), then now full and not cropped item names are displayed.
Describe the solution
I'd added cycle which search max items length and resize shift-v items window. Also there is check for max game window width.
Describe alternatives you've considered
Scrolling, but all the appropriate keys are busy.
Testing