Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended shift-v items menu #36663

Merged
merged 15 commits into from
Apr 2, 2020
Merged

Extended shift-v items menu #36663

merged 15 commits into from
Apr 2, 2020

Conversation

8street
Copy link
Contributor

@8street 8street commented Jan 3, 2020

Summary

SUMMARY: Interface "Extended shift-v items menu"

Purpose of change

If a player is looking around (shift-v items menu), then now full and not cropped item names are displayed.

Describe the solution

I'd added cycle which search max items length and resize shift-v items window. Also there is check for max game window width.

Describe alternatives you've considered

Scrolling, but all the appropriate keys are busy.

Testing

fix9

@KorGgenT
Copy link
Member

KorGgenT commented Jan 3, 2020

how does this look with minimum screen size

src/game.cpp Outdated Show resolved Hide resolved
@8street
Copy link
Contributor Author

8street commented Jan 3, 2020

how does this look with minimum screen size

fix10

Umm, I figured out how to modify this PR. Coming soon.

@8street 8street changed the title Extended shift-v items menu [WIP] Extended shift-v items menu Jan 3, 2020
@8street
Copy link
Contributor Author

8street commented Jan 4, 2020

fix11

Now it looks more adequate with a minimum window size. With a large window, it looks like in my first screenshot.

@8street 8street changed the title [WIP] Extended shift-v items menu Extended shift-v items menu Jan 4, 2020
@curstwist curstwist added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` labels Jan 6, 2020
@8street
Copy link
Contributor Author

8street commented Jan 8, 2020

I'd resolved conflicts. Can be merged. Also PR fixes #36787: width of the list_items was also hardcoded in reset_item_list_state(), with code const int width = 44;, which did not change in the mentioned PR. In my PR I replaced it to const int width = getmaxx( window );

@kevingranade kevingranade merged commit db5ba71 into CleverRaven:master Apr 2, 2020
@8street 8street deleted the Extended-shift-v-menu branch April 3, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants