Dynamically scale overmap legend width

[Night-Pryanik]

Summary

SUMMARY: Interface "Dynamic overmap legend width."

Purpose of change

Current overmap legend width is fixed to 28 symbols, which is very low and isn't enough for long descriptions. This is especially bad for high-resolution monitors since there is a lot of free space to fit long texts.

Describe the solution

Made overmap legend width scale dynamically based on size of terminal. Its width now is one-fifth of the terminal size, clamped to be no less than 28 and no more than 55 symbols.

Describe alternatives you've considered

Use folding for all strings where it should be considered appropriate, but it cures the symptoms, not the cause of the problem.

Testing

Started game, opened overmap, checked for overmap legend width.

Additional context

Before (in Russian). Russian translation is longer than the original text, so it is overlapped to the next string

After (clamped to max of 55 symbols on my resolution)

[GGgatherer]

I guess this is what broke my overmap legend :)

Hotkeys still work, though.

• OS: Windows 7 x64
• Game Version: 0.D-10984-ged9e547 [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Modular Turrets [modular_turrets],
  Salvaged Robots [Salvaged_Robots],
  Alternative Map Key [alt_map_key],
  sees-player icon, retrodays [sees_player_retro],
  Stats Through Skills [StatsThroughSkills]
  ]

[Night-Pryanik]

Did you resize the game window?

[GGgatherer]

No, I play in borderless windowed mode, no scaling, 192x54 terminal(according to the game it equals 1920x1080, my display native resolution).

[ZhilkinSerg]

Font settings?

[Lamandus]

same for me. Fonts are own settings and this will cause the error.
For me:
{
"typeface": [ "Atari", "unifont" ],
"map_typeface": "unifont",
"overmap_typeface": "map_font_LARWICK.png"
}

[anothersimulacrum]

Did you change fontsize? I triggered this with just a different font size (10x10, instead of 8x16).

[Lamandus]

reverted back to the old font size resolves the issue, true, but the map mod is now not working correctly of course.

[Lamandus]

my standard setting.
Interestingly enough, when setting to 10x10 it just shows the city name, nothing else:

[GGgatherer]

my fonts.json:

{
 "fontblending": true,
 "fontwidth": 16,
 "fontheight": 32,
 "fontsize": 32,
 "typeface": "Consolas Bold",
 "map_fontwidth": 16,
 "map_fontheight": 32,
 "map_fontsize": 32,
 "map_typeface": "Consolas Bold",
 "overmap_typeface": "unifont"
}

So yeah, different font size from default.

[kevingranade]

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/no-sidebar-in-overmap-screen/22394/2

[BevapDin]

The overmap window can have a different w´font than the rest of the game windows. Have you checked what happens when the overmap font is much larger and what if it the font is much smaller? I assume it's possible the overmap window itself overlays the legend window. Or the legend window is just too much to the left, so it's under the overmap window.

[Night-Pryanik]

Have you checked what happens when the overmap font is much larger and what if it the font is much smaller?

No, I tested it only on default font dimensions.

[doktorstick]

Same problem. Adding my info here as I have a 16:10 screen (2560x1600).

Settings:

Font:

{
       "fontblending": true,
       "fontwidth": 12,
       "fontheight": 24,
       "fontsize": 24,
       "typeface": ["Consolas Bold", "unifont"],
       "map_fontwidth": 12,
       "map_fontheight": 24,
       "map_fontsize": 24,
       "map_typeface": "Consolas Bold",
       "overmap_fontwidth": 22,
       "overmap_fontheight": 22,
       "overmap_fontsize": 22,
       "overmap_typeface": "whitrabt"
}

[AdonaiJr]

Same here. 1920x1080, overmap fontsizes 10x10x10. I can see only a litte bit of the legend window on the bottom of the screen. Looks like in my case happened what BevapDin said: "Or the legend window is just too much to the left, so it's under the overmap window".

[doktorstick]

Since this new feature broke the overmap for non-default players, would you please revert these changes until a proper fix can be made?

[anothersimulacrum]

No need to revert it, #36879 will fix it.