unify savegame version and bump to 27 #36654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw: what's the purpose of bumping the savegame version in the middle of nowhere (without any change to the savegame format)? Both savegame version (the old 26 and the new 27) have the exact same format and load in the exact same way. |
|
so that when #36576 is merged everyone on experimental won't have their food rot in their hands. now that this is in i'll rebase and wait a few days to let people catch up |
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: nonePurpose of change
This unifies all of the different savegame versions that are saved via overmap and such into one savegame_loading_version, which makes it a lot easier to update the savegame version when new rules are needed for migration reasons.
Testing
the first half of #36576 and tested as part of that.
Additional context
I wish i had known about the different savegame versions before christmas when i did the first bump, but oh well.