-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renovate house 04 #36640
renovate house 04 #36640
Conversation
I'd like to see |
standard_building_palette is better suited to commercial spaces, since it only has glass doors and walls. I could revamp this with domestic buildings in mind, or, I'm thinking of doing a residential version of your standard palette, then having one that is exclusively domestic furniture and loot spawns. Taking care that the two don't have symbol conflicts. That way we can use these going forward for new houses and recommend them as a best practice. The problem with my house_w series is that they assume you are using a nest for most furniture (except bathroom and kitchen) and takes advantage of that to reuse symbols across the two palettes. In the end, our enemy for fully standardized palettes is the lack of symbol variety. |
|
I'd like to add variety entries to
vs.
If that works for your original intentions, I'll go ahead and adapt it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just that we should try to avoid using t_grass in definitions when possible, so that any biomes that are grass-free don't show up with unexpected patches of it.
"overmaps": [ | ||
{ "point": [ 0, 0, 0 ], "overmap": "house_04_north" }, | ||
{ "point": [ 0, 0, 1 ], "overmap": "house_04_roof_north" }, | ||
{ "point": [ 0, 0, -1 ], "overmap": "basement" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make a custom basement for house_04 and all these houses? Not in this PR but I could probably whip something up quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
none of the stairs are going to line up, you're call if you want to take them on. Right now they all pull from the general basement list.
Co-Authored-By: I-am-Erk <[email protected]>
Summary
SUMMARY: Content "Adds roof and renovates house04"
Purpose of change
Begin the long process of updating the existing houses.
Describe the solution
For each house the following work needs to be done:
Describe alternatives you've considered
Using a dedicated housing palettes to make these uniform. I'm open to using my existing house_w series of palettes if other contributors prefer this approach. It'll take more 'translation' work on the existing maps.
Begin adding nested mapgen if I see an opportunity, but again this would considerably increase the time spent per house.
I've been trending away from a lot of metal furniture in domestic buildings because it doesn't seem to be very common in reality. This will impact crafting a fair amount so I wanted to mention it for discussion. For example, I favor wooden racks over the metal racks, which I imagine are a more commercial rack like in a grocery store.
Testing
Spawned in game.
Additional context