Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magiclysm: Cooking with Poison #36627

Merged
merged 14 commits into from
Jan 4, 2020

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Jan 2, 2020

Summary

SUMMARY: Mods "Demon Chitin Cookware and it's uses"

Purpose of change

I realized that the mage on the go needed demon spider chitin cookware and what would make sense for this cookware to do? Remove poisons and help to mix magical ingredients in a large evil looking cauldron.

Describe the solution

Adds a recipe book "Cooking with Poison" which includes recipes for the Cauldron, several things that can be made with the cauldron, a new tool quality that hopefully will be helpful when Magiclysm mutation lines become a thing and updates itemgroups to include appropriately.

Describe alternatives you've considered

Using the cauldron to create an army of the undead as a true disciple of the Horned King.

Testing

Testing tonight and made changes until it loaded fine and all items could be created without visible errors in game or in Travis.

Additional context

Cauldron, recipe for the tool, tool quality, recipe book, itemgroup addition and recipes for the Cooking with Poison book.
@Maleclypse
Copy link
Member Author

@KorGgenT @laveyanfiend per our conversation last week, I've created demon chitin cookware. Let me know what you think works and what doesn't. :)

@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods: Magiclysm Anything to do with the Magiclysm mod labels Jan 2, 2020
@Maleclypse Maleclypse changed the title WIP Magiclysm: Cooking with Poison Magiclysm: Cooking with Poison Jan 3, 2020
@KorGgenT KorGgenT self-assigned this Jan 3, 2020
"category": "other",
"name": { "str": "cauldron of purification", "str_pl": "cauldrons of purification" },
"description": "This cauldron made of demon spider chitin seems to absorb the light. It will hold 16 liters of material and will absorb poisons from it. It may have other properties that require discovery.",
"weight": "1424 g",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i didn't catch this earlier, but for a 20 L object, 3 pounds is very very light.

Copy link
Member Author

@Maleclypse Maleclypse Jan 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I used straight math for demon chitin and bowl volume. If the cauldron contains 16 L of volume that means 4 L of material. Each chunk of demon chitin is 250 ml so 16 chunks to make the cauldron. 4 L of Demon chitin chunks at 89 grams per 250 ml comes out to 1424 exactly. I'm good to update it to whatever you think is best but I feel it's important to show my math and why I will need you to let me know what it should actually be? I can add the bone glue in weight but that only adds 450 g in weight.

Edit: I could be totally wrong on how I calculated the volume of material needed though,

@KorGgenT KorGgenT merged commit 5c8e01c into CleverRaven:master Jan 4, 2020
@Maleclypse Maleclypse deleted the Magiclysm-Demon-Cookware branch April 13, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants