Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alcohol Revamp #36619

Merged
Merged

Conversation

LilShiningMan
Copy link
Contributor

SUMMARY: Infrastructure "Alcohol item groups revamp"

Summary

Granularized main alcohol groups, eliminated redundant lists in various item groups.

Purpose of change

More house cleaning of item groups.

Describe the solution

Broke various alcoholic beverages into main categories (beer, liquor and spirits, mixed, misc) to complement existing wines_worthy; eliminated redundant item entries and called groups instead.

Describe alternatives you've considered

Testing

Delinted and debug spawned item groups ingame.

Additional context

I removed chem_ethanol from alcohol and alcohol_bottled_canned groups and added it to the science item list. It already appears in the reagents supply group and a few other item lists. It just didn't belong with potable alcohol.

Granularized main alcohol groups, eliminated redundant lists in various item groups.
@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map labels Jan 2, 2020
@kevingranade kevingranade merged commit f6eb74d into CleverRaven:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants