Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate stealing code #36596

Merged
merged 9 commits into from
Jan 2, 2020
Merged

Remove duplicate stealing code #36596

merged 9 commits into from
Jan 2, 2020

Conversation

8street
Copy link
Contributor

@8street 8street commented Dec 31, 2019

Summary

SUMMARY: Bugfixes "Remove duplicate stealing code in pickup.cpp"

Purpose of change

When player pickuping items, if the item has charges, then several stealing symbols ( ! ) are displayed. PR fix this.

Describe the solution

I'd removed duplicate stealing code. Now the stealing check happens once.

Describe alternatives you've considered

Testing

Before
fix3

After
fix4

src/pickup.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Jan 2, 2020
@ZhilkinSerg ZhilkinSerg merged commit fe0e3de into CleverRaven:master Jan 2, 2020
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Jan 2, 2020
@8street 8street deleted the Remove-duplicate-stealing-code branch January 18, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants