Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbox qualities fix #36537

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Toolbox qualities fix #36537

merged 2 commits into from
Dec 30, 2019

Conversation

RarkGrames
Copy link
Contributor

@RarkGrames RarkGrames commented Dec 29, 2019 •
edited
Loading

Summary

SUMMARY: Bugfixes "Fixed toolbox having extra tool qualities"

Purpose of change

The toolbox has filing, vicing and reaming qualities without actually having the tools for them.

Describe the solution

  • Removing the qualities from the toolbox
  • Adding a workshop toolbox item
  • Adding a recipe for the workshop toolbox that additionally requires a set of files, a hand vice and a pin reamer
  • Adding the workshop toolbox to item groups

Testing

  • Spawned the new toolbox and checked the qualities
  • Tested the item group spawnrates with the debug menu

@curstwist curstwist added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 29, 2019
@kevingranade kevingranade merged commit c532fc4 into CleverRaven:master Dec 30, 2019
@RarkGrames RarkGrames deleted the Toolbox-qualities-fix branch December 30, 2019 07:10
This was referenced Jan 5, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RarkGrames @kevingranade @curstwist