aluminum dmg_adj string changed to "destroyed" #36524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerimee
changed the title
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
To provide better verbiage for extreme damage to aluminum
Describe the solution
Replaced the word "shattered" with "destroyed."
Describe alternatives you've considered
I did a bunch of googling to try to have a better sense of the material physics of extreme forces upon hard metals and alloys, but I'm not sure the science is even a primary concern here.
I considered that perhaps the term "shattered" was preferable for having connotations of epic and extreme proportions. It might be a more fun or exciting description.
Testing
None!
Additional context
I suspect, even in cases of extreme destructive forces, it is more common for aluminum (and other metals) to deform without shattering. This PR only changes aluminum, for better or for worse.