Fix the ENCUMBRANCE_UPDATE flag again: #36503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means: - it's ignored when comparing items (items with the flag stack together with items that don't have the flag), - it's not saved, it's temporary anyway.
curstwist
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: NoneTurns out the flag is added to all containers when they change their content. For example: you have two identical 60l tanks (they appear as one stack in the game UI). Now fill one with some liquid and unload it again. That tank will now have the ENCUMBRANCE_UPDATE flag. And the other doesn't, so they don't stack anymore. And the tank is not worn, so the code that checks for the flag and removes it is not run for the item. It essentially keeps the flag forever.